Avoid competing swagger generation during test build #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation caused the concurrent builds for various frameworks to compete in writing to the output `swagger.json` file, causing exceptions during builds (since it happened in csproj). In my local development I often failed to rebuild the full solution because some projects failed to build for this reason. It has also happened in CI (domaindrivendev#2886). Note that the NSwag source code generator in `NswagClientExample` still outputs everything in one spot for all frameworks, but I haven't noticed failures from that. Maybe it's just less likely to write concurrently. I left it as is.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 72 72
Lines 2706 2706
Branches 428 428
=======================================
Hits 2432 2432
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Do you think this will fix that flaky test from yesterday? If so, can you unskip it? |
Yes, this was one of the issues I noticed. I'll try to unskip the test. |
|
Just re-running the last build a few times to be sure... |
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
May 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Swashbuckle.AspNetCore](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore) | `6.6.1` -> `6.6.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>domaindrivendev/Swashbuckle.AspNetCore (Swashbuckle.AspNetCore)</summary> ### [`v6.6.2`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.6.2) #### What's Changed - Fix to make required and nullable properties nullable in schema by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2879](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2879) - Update Swagger UI section in README by [@​cremor](https://togithub.com/cremor) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2883](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2883) - Add support for the `[Length]`attribute. by [@​satma0745](https://togithub.com/satma0745) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882) - Existing output file should be deleted/overwritten by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886) - Fix libraries being handled as test projects by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2898](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2898) - Avoid competing swagger generation during test build by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2897](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2897) - Replace `<br />`, `<br/>`, and `<br>` in XML comments with `Environment.Newline` by [@​mburumaxwell](https://togithub.com/mburumaxwell) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2899](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2899) - Fix schema generation for [c#9](https://togithub.com/c/Swashbuckle.AspNetCore/issues/9) positional record with param tag without example property creating unexpected empty example by [@​stb-co](https://togithub.com/stb-co) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901) - Fix serialization of `AdditionalItems` by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2890](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2890) - Disable parallel build by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2894](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2894) - Do not run `IHostedService` implementations by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2880](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2880) - Fix interceptor JSON casing by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2907](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2907) - Fix generation when `[DefaultValue]`'s type differs by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2895](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2895) #### New Contributors - [@​satma0745](https://togithub.com/satma0745) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882) - [@​patrikwlund](https://togithub.com/patrikwlund) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886) - [@​stb-co](https://togithub.com/stb-co) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.6.1...v6.6.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in smartive/cas-fee-adv-mumble-api
May 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Swashbuckle.AspNetCore](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore) | `6.5.0` -> `6.6.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [Swashbuckle.AspNetCore.Annotations](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore) | `6.5.0` -> `6.6.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>domaindrivendev/Swashbuckle.AspNetCore (Swashbuckle.AspNetCore)</summary> ### [`v6.6.2`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.6.2) #### What's Changed - Fix to make required and nullable properties nullable in schema by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2879](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2879) - Update Swagger UI section in README by [@​cremor](https://togithub.com/cremor) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2883](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2883) - Add support for the `[Length]`attribute. by [@​satma0745](https://togithub.com/satma0745) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882) - Existing output file should be deleted/overwritten by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886) - Fix libraries being handled as test projects by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2898](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2898) - Avoid competing swagger generation during test build by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2897](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2897) - Replace `<br />`, `<br/>`, and `<br>` in XML comments with `Environment.Newline` by [@​mburumaxwell](https://togithub.com/mburumaxwell) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2899](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2899) - Fix schema generation for [c#9](https://togithub.com/c/Swashbuckle.AspNetCore/issues/9) positional record with param tag without example property creating unexpected empty example by [@​stb-co](https://togithub.com/stb-co) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901) - Fix serialization of `AdditionalItems` by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2890](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2890) - Disable parallel build by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2894](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2894) - Do not run `IHostedService` implementations by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2880](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2880) - Fix interceptor JSON casing by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2907](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2907) - Fix generation when `[DefaultValue]`'s type differs by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2895](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2895) #### New Contributors - [@​satma0745](https://togithub.com/satma0745) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2882) - [@​patrikwlund](https://togithub.com/patrikwlund) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2886) - [@​stb-co](https://togithub.com/stb-co) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2901) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.6.1...v6.6.2 ### [`v6.6.1`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.6.1) #### What's Changed - Modernise build and migrate to GitHub Actions for CI by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2775](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2775) - Update Redoc spelling in docs by [@​Quppa](https://togithub.com/Quppa) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2568](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2568) - C# 9 Record - Read example/summary from positional record by [@​pixellos](https://togithub.com/pixellos) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2546](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2546) - Grammatical correction of some comments by [@​mokarchi](https://togithub.com/mokarchi) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2768](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2768) - Update README.md for nested types custom schemaId support by [@​antmeehan](https://togithub.com/antmeehan) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2746](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2746) - Add support for `WithSummary` and `WithDescription` metadata by [@​hwoodiwiss](https://togithub.com/hwoodiwiss) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2414](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2414) - Update README.md - Fix `Add Security Definitions and Requirements for Bearer auth` URL by [@​Saibamen](https://togithub.com/Saibamen) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2705](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2705) - Replace <see href="link">text</see> with Markdown link format by [@​mburumaxwell](https://togithub.com/mburumaxwell) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2392](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2392) - Add support for required keyword by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2810](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2810) - Resolves [#​2717](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2717) by [@​MerickOWA](https://togithub.com/MerickOWA) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2718](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2718) - Observe the route template constraints in the Swagger middleware by [@​0xced](https://togithub.com/0xced) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2418](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2418) - Added Swashbuckle.AspNetCore.Annotations.SwaggerIgnoreAttribute by [@​jcracknell](https://togithub.com/jcracknell) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2610](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2610) - Fix schema generation with allOf inheritance by [@​bkoelman](https://togithub.com/bkoelman) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2815](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2815) - avoid triple enumeration of formParameters by [@​SimonCropp](https://togithub.com/SimonCropp) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2823](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2823) - reduce some linq allocation by [@​SimonCropp](https://togithub.com/SimonCropp) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2819](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2819) - remove some duplicate dictionary lookups by [@​SimonCropp](https://togithub.com/SimonCropp) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2822](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2822) - remove redundant any check in InferRequestContentTypes by [@​SimonCropp](https://togithub.com/SimonCropp) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2824](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2824) - Correctly respect interfaces in `GetInheritanceChain` by [@​angelaki](https://togithub.com/angelaki) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2826](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2826) - Generate Enum-Dictionary-Keys (analogous to Newtonsoft) by [@​angelaki](https://togithub.com/angelaki) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2825](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2825) - Fix build badge by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2782](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2782) - Fix preview package versions by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2783](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2783) - Handle Stream and PipeReader content types correctly by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2784](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2784) - Add NuGet package READMEs by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2808](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2808) - Bump redoc to 2.1.3 by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2807](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2807) - Sort system usings first by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2790](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2790) - Throw if unsupported HTTP method used by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2797](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2797) - Fix configuration properties not being copied by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2796](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2796) - Add security policy by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2785](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2785) - Bump Microsoft.OpenApi by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2795](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2795) - Update to Swagger UI v5 by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2806](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2806) - Add customized document serialization support by [@​remcolam](https://togithub.com/remcolam) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2677](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2677) - Added documentation for ISwaggerDocumentSerializer by [@​remcolam](https://togithub.com/remcolam) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2837](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2837) - Fix flaky tests by locking on the statup type by [@​remcolam](https://togithub.com/remcolam) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2838](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2838) - [#​2765](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/issues/2765) Allow Filter instance reuse by [@​remcolam](https://togithub.com/remcolam) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2839](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2839) - Throw an error when a user uses FromForm attribute with IFormFile in … by [@​nikunjbhargava](https://togithub.com/nikunjbhargava) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2840](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2840) - Filter illegal header fields by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2842](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2842) - Fix handling of FileResult's with content types by [@​IGx89](https://togithub.com/IGx89) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2841](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2841) - Adding additional responses when 5XX errors are thrown. by [@​say25](https://togithub.com/say25) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2852](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2852) - Fix that XML comment examples do not show up if the type is string and the example contains quotation marks by [@​dldl-cmd](https://togithub.com/dldl-cmd) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2727](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2727) - Exclude unused Swagger-UI files by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2851](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2851) - Fix RequestBodyFilters not being deep copied by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2850](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2850) - Avoid GitHub step summary file write conflicts by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2848](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2848) - Extend built-in supported types by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2804](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2804) - Update compatibility table by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2856](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2856) - Add GitHub issue and PR templates by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2788](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2788) - Fix stale permissions by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2855](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2855) - Add .NET 8 support by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2799](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2799) - Release automation workflows by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2809](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2809) - Support native AoT with SwaggerUI by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2800](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2800) - Bump some NuGet packages by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2868](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2868) - Fix stale permissions by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2863](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2863) - Attestation by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2869](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2869) - Add descriptions for more HTTP status codes by [@​cremor](https://togithub.com/cremor) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2872](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2872) - Only attest packages by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2870](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2870) - Fix tag version by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2875](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2875) #### New Contributors - [@​mokarchi](https://togithub.com/mokarchi) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2768](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2768) - [@​hwoodiwiss](https://togithub.com/hwoodiwiss) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2414](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2414) - [@​Saibamen](https://togithub.com/Saibamen) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2705](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2705) - [@​keahpeters](https://togithub.com/keahpeters) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2810](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2810) - [@​MerickOWA](https://togithub.com/MerickOWA) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2718](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2718) - [@​0xced](https://togithub.com/0xced) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2418](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2418) - [@​jcracknell](https://togithub.com/jcracknell) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2610](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2610) - [@​bkoelman](https://togithub.com/bkoelman) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2815](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2815) - [@​angelaki](https://togithub.com/angelaki) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2826](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2826) - [@​remcolam](https://togithub.com/remcolam) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2677](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2677) - [@​nikunjbhargava](https://togithub.com/nikunjbhargava) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2840](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2840) - [@​IGx89](https://togithub.com/IGx89) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2841](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2841) - [@​dldl-cmd](https://togithub.com/dldl-cmd) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2727](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2727) - [@​cremor](https://togithub.com/cremor) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2872](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2872) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.5.0...v6.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/smartive/cas-fee-adv-mumble-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC4xMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation caused the concurrent builds for various frameworks to compete in writing to the output
swagger.jsonfile, causing exceptions during builds (since it happened in csproj).In my local development I often failed to rebuild the full solution because some projects failed to build for this reason. It has also happened in CI (#2886).
Note that the NSwag source code generator in
NswagClientExamplestill outputs everything in one spot for all frameworks, but I haven't noticed failures from that. Maybe it's just less likely to write concurrently. I left it as is.